Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCC] if synchronous, reset non-pending #477

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[OCC] if synchronous, reset non-pending #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions tasks/scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,14 +506,21 @@ func (s *scheduler) executeTask(task *deliverTxTask) {
task.Ctx = dCtx

// in the synchronous case, we only want to re-execute tasks that need re-executing
// if already validated, then this does another validation
if s.synchronous && task.IsStatus(statusValidated) {
s.shouldRerun(task)
if s.synchronous {
// if already validated, then this does another validation
if task.IsStatus(statusValidated) {
return
s.shouldRerun(task)
if task.IsStatus(statusValidated) {
return
}
}

// waiting transactions may not yet have been reset
// this ensures a task has been reset and incremented
if !task.IsStatus(statusPending) {
task.Reset()
task.Increment()
}
task.Reset()
task.Increment()
}

s.prepareTask(task)
Expand Down
Loading