Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework abort handling to not be dependent on extracting codes from delivertx errors #465

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Mar 19, 2024

Describe your changes and provide context

This should appropriately allow for cases where panics are recovered and swallowed earlier because we now simply use the panic to abort execution, and detect that an abort occurred by reading the abort channel as the source of truth

Testing performed to validate your change

Scheduler tests, and need to test alongside atlantic-2

@udpatil udpatil requested a review from stevenlanders March 19, 2024 16:04
Copy link
Contributor

@stevenlanders stevenlanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not panicking, as long as there can only be a limited number of aborts (e.g., size of stores list), this is fine, otherwise the deliverTx may hang and we may have to go back to the async deliverTx while draining abort channel shape.

@udpatil udpatil merged commit e8a28d3 into main Mar 19, 2024
13 checks passed
@udpatil udpatil deleted the occ-abort-refactor branch March 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants