Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sync fallback to apropriately validate and re-excute as necessary #461

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Mar 13, 2024

Describe your changes and provide context

This refactors the sync fallback such that it will re-execute (and revalidate validated to determine if they need execution) synchronously after exceeding maxIterations

Testing performed to validate your change

Unit test + need to perform loadtesting on main, some loadtesting performed one the seiv2 version

@udpatil udpatil requested a review from stevenlanders March 13, 2024 22:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.44%. Comparing base (df756ef) to head (f7f3843).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   55.46%   55.44%   -0.02%     
==========================================
  Files         629      629              
  Lines       53529    53541      +12     
==========================================
- Hits        29689    29688       -1     
- Misses      21729    21740      +11     
- Partials     2111     2113       +2     
Files Coverage Δ
store/multiversion/store.go 90.96% <100.00%> (+0.06%) ⬆️
tasks/scheduler.go 89.97% <70.83%> (-3.44%) ⬇️

@udpatil udpatil merged commit 0320b34 into main Mar 14, 2024
13 checks passed
@udpatil udpatil deleted the sync-fallback branch March 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants