-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding token factory specific denom endpoint #457
Merged
dssei
merged 9 commits into
main
from
SEI-5441_additional_denom_ednpoint_for_tokenfoundry
Mar 14, 2024
Merged
Adding token factory specific denom endpoint #457
dssei
merged 9 commits into
main
from
SEI-5441_additional_denom_ednpoint_for_tokenfoundry
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat factory/<owner_wallet>/<denom> in a separate query param rather than URI param.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 55.46% 55.52% +0.05%
==========================================
Files 629 629
Lines 53541 53543 +2
==========================================
+ Hits 29695 29728 +33
+ Misses 21733 21700 -33
- Partials 2113 2115 +2
|
philipsu522
approved these changes
Mar 13, 2024
yzang2019
approved these changes
Mar 14, 2024
…41_additional_denom_ednpoint_for_tokenfoundry
dssei
added a commit
that referenced
this pull request
Mar 19, 2024
Reverts #457 in favor of sei-protocol/sei-chain#1444 as tokenfactory is more appropriate module for the endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
When we create tokens using token factory, denoms are created in the
factory/{owner_walltet_id}/{denom}
formatE.g.
factory/sei1gxskuzvhr4s8sdm2rpruaf7yx2dnmjn0zfdu9q/NEWCOIN
When querying metadata via
/cosmos/bank/v1beta1/denoms_metadata/{denom}
endpoint for such a denom we are getting error likeThis happens, because routing logic splits the denom uri param into 3 components rather then one and hence tries to router request to a non-existing handler. Url encoding does not help either as it still results in same issue. We would like to add additional endpoint to handle token factory created metadata retrieval, and move denom for the endpoint from uri param to query param.
so then for token factory created tokens the query would be
/cosmos/bank/v1beta1/token_factory/denoms_metadata?denom=factory/{owner_walltet_id}/{denom}
Testing performed to validate your change
Note: some demom tests were disables, and I have enabled them.