Fix indexesValidated and PrefillEstimates to operate on absolute idx #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #454 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 629 629
Lines 53817 53823 +6
=======================================
+ Hits 29791 29796 +5
- Misses 21896 21897 +1
Partials 2130 2130
|
philipsu522
approved these changes
Mar 8, 2024
| mappedWritesets := req.EstimatedWritesets | ||
| // order shouldnt matter for storeKeys because each storeKey partitioned MVS is independent | ||
| for storeKey, writeset := range mappedWritesets { | ||
| // we use `-1` to indicate a prefill incarnation | ||
| s.multiVersionStores[storeKey].SetEstimatedWriteset(i, -1, writeset) | ||
| s.multiVersionStores[storeKey].SetEstimatedWriteset(req.AbsoluteIndex, -1, writeset) |
There was a problem hiding this comment.
would it be easy to add a unit test for this?
There was a problem hiding this comment.
yeah, good point, we have a simple unit test to assert the proper values in the MultiVersionStore, I'll add one in
yzang2019
approved these changes
Mar 9, 2024
stevenlanders
approved these changes
Mar 11, 2024
udpatil
added a commit
that referenced
this pull request
Mar 11, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Mar 14, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Mar 26, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Mar 26, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Mar 27, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Apr 16, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Apr 19, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
udpatil
added a commit
that referenced
this pull request
Apr 19, 2024
…454) This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative. Existing unit tests + loadtesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This is one component that was missed when refactoring to use absolute indices for EVM changes. This change refactors such that prefill estimates will appropriately fill the estimates by absolute Index and indexes validated will similarly check via absolute indices instead of relative.
Testing performed to validate your change
Existing unit tests + loadtesting