Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax locking contention #427

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Relax locking contention #427

merged 2 commits into from
Feb 9, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Feb 8, 2024

Describe your changes and provide context

This reduces some of the locking contention experienced when executing transactions with OCC. Additionally, undoes an earlier revert that reintroduced some locking for event emission

Testing performed to validate your change

@udpatil udpatil requested a review from stevenlanders February 8, 2024 22:35
@udpatil udpatil force-pushed the tracing-enabled-flag branch from 247452e to f4088ad Compare February 8, 2024 22:41
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 193 lines in your changes are missing coverage. Please review.

Comparison is base (fb803dd) 55.51% compared to head (f4088ad) 55.43%.
Report is 32 commits behind head on occ-main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           occ-main     #427      +/-   ##
============================================
- Coverage     55.51%   55.43%   -0.08%     
============================================
  Files           629      629              
  Lines         53476    53475       -1     
============================================
- Hits          29687    29644      -43     
- Misses        21683    21721      +38     
- Partials       2106     2110       +4     
Files Coverage Δ
server/config/toml.go 17.85% <ø> (ø)
server/start.go 21.76% <100.00%> (ø)
store/cachekv/mergeiterator.go 79.22% <100.00%> (-0.66%) ⬇️
store/cachekv/store.go 80.82% <100.00%> (+0.91%) ⬆️
store/multiversion/data_structures.go 100.00% <100.00%> (ø)
store/multiversion/trackediterator.go 100.00% <100.00%> (ø)
store/types/store.go 68.75% <ø> (ø)
types/accesscontrol/resource.go 0.00% <ø> (ø)
types/accesscontrol/validation.go 82.00% <ø> (ø)
types/context.go 73.88% <100.00%> (ø)
... and 19 more

... and 2 files with indirect coverage changes

@udpatil udpatil requested a review from yzang2019 February 9, 2024 02:35
@udpatil udpatil merged commit 48dfff5 into occ-main Feb 9, 2024
15 checks passed
@udpatil udpatil deleted the tracing-enabled-flag branch February 9, 2024 02:37
udpatil added a commit that referenced this pull request Feb 27, 2024
## Describe your changes and provide context
This reduces some of the locking contention experienced when executing
transactions with OCC. Additionally, undoes an earlier revert that
reintroduced some locking for event emission

## Testing performed to validate your change
udpatil added a commit that referenced this pull request Mar 1, 2024
## Describe your changes and provide context
This reduces some of the locking contention experienced when executing
transactions with OCC. Additionally, undoes an earlier revert that
reintroduced some locking for event emission

## Testing performed to validate your change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants