Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Allow multiple txs from same account in a block #397

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented Jan 18, 2024

Describe your changes and provide context

  • needs tendermint pr and go.mod update
  • adds evm properties to the ResponseCheckTxV2
  • adds evm properties to context

Testing performed to validate your change

  • hardhat tests on sei-chain repo
  • unit tests on tendermint repo

@stevenlanders stevenlanders marked this pull request as ready for review January 18, 2024 18:40
@@ -226,22 +226,27 @@ func (app *BaseApp) CheckTx(ctx context.Context, req *abci.RequestCheckTx) (*abc
res := sdkerrors.ResponseCheckTx(err, 0, 0, app.trace)
return &abci.ResponseCheckTxV2{ResponseCheckTx: &res}, err
}
gInfo, result, _, priority, pendingTxChecker, expireTxHandler, err := app.runTx(sdkCtx, mode, tx, sha256.Sum256(req.Tx))
gInfo, result, _, priority, pendingTxChecker, expireTxHandler, txCtx, err := app.runTx(sdkCtx, mode, tx, sha256.Sum256(req.Tx))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we can group some of those mempool-specific return values into a struct for readability sake

@stevenlanders stevenlanders merged commit 881a69e into evm-temp Jan 19, 2024
14 checks passed
@stevenlanders stevenlanders deleted the add-evm-info-to-check-response branch January 19, 2024 16:05
stevenlanders added a commit that referenced this pull request Jan 30, 2024
## Describe your changes and provide context
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

## Testing performed to validate your change
- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Jan 31, 2024
## Describe your changes and provide context
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

## Testing performed to validate your change
- hardhat tests on sei-chain repo
- unit tests on tendermint repo
stevenlanders added a commit that referenced this pull request Feb 6, 2024
## Describe your changes and provide context
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

## Testing performed to validate your change
- hardhat tests on sei-chain repo
- unit tests on tendermint repo
stevenlanders added a commit that referenced this pull request Feb 8, 2024
## Describe your changes and provide context
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

## Testing performed to validate your change
- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Feb 28, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Feb 28, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 1, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 4, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
codchen pushed a commit that referenced this pull request Mar 7, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 11, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 14, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 26, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 26, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Mar 27, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Apr 16, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Apr 19, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
udpatil pushed a commit that referenced this pull request Apr 19, 2024
- needs tendermint pr and go.mod update
- adds evm properties to the `ResponseCheckTxV2`
- adds evm properties to context

- hardhat tests on sei-chain repo
- unit tests on tendermint repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants