-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] Allow multiple txs from same account in a block #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
approved these changes
Jan 19, 2024
@@ -226,22 +226,27 @@ func (app *BaseApp) CheckTx(ctx context.Context, req *abci.RequestCheckTx) (*abc | |||
res := sdkerrors.ResponseCheckTx(err, 0, 0, app.trace) | |||
return &abci.ResponseCheckTxV2{ResponseCheckTx: &res}, err | |||
} | |||
gInfo, result, _, priority, pendingTxChecker, expireTxHandler, err := app.runTx(sdkCtx, mode, tx, sha256.Sum256(req.Tx)) | |||
gInfo, result, _, priority, pendingTxChecker, expireTxHandler, txCtx, err := app.runTx(sdkCtx, mode, tx, sha256.Sum256(req.Tx)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we can group some of those mempool-specific return values into a struct for readability sake
stevenlanders
added a commit
that referenced
this pull request
Jan 30, 2024
## Describe your changes and provide context - needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context ## Testing performed to validate your change - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context - needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context ## Testing performed to validate your change - hardhat tests on sei-chain repo - unit tests on tendermint repo
stevenlanders
added a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context - needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context ## Testing performed to validate your change - hardhat tests on sei-chain repo - unit tests on tendermint repo
stevenlanders
added a commit
that referenced
this pull request
Feb 8, 2024
## Describe your changes and provide context - needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context ## Testing performed to validate your change - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 1, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
codchen
pushed a commit
that referenced
this pull request
Mar 7, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 14, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Mar 27, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Apr 16, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
- needs tendermint pr and go.mod update - adds evm properties to the `ResponseCheckTxV2` - adds evm properties to context - hardhat tests on sei-chain repo - unit tests on tendermint repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
ResponseCheckTxV2
Testing performed to validate your change