[OCC] Fix hang where abort channel blocks iterator #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenlanders
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## occ-main #379 +/- ##
============================================
+ Coverage 56.12% 56.14% +0.02%
============================================
Files 627 627
Lines 52887 52914 +27
============================================
+ Hits 29682 29708 +26
- Misses 21097 21098 +1
Partials 2108 2108
|
udpatil
reviewed
Dec 12, 2023
tasks/scheduler.go
Outdated
| @@ -442,7 +441,8 @@ func (s *scheduler) prepareTask(task *deliverTxTask) { | |||
| } | |||
|
|
|||
| // executeTask executes a single task | |||
| func (s *scheduler) executeTask(task *deliverTxTask) { | |||
| func (s *scheduler) executeTask3(task *deliverTxTask) { | |||
There was a problem hiding this comment.
is this just for preserving the old impl?
There was a problem hiding this comment.
nope- this was an oversight that needs removing :)
udpatil
approved these changes
Dec 12, 2023
udpatil
pushed a commit
that referenced
this pull request
Jan 2, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 25, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Feb 27, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
udpatil
pushed a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context - instead of assuming one thing will arrive to the abort channel, drain it ## Testing performed to validate your change - new unit test captures situation (tests iterator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change