Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose parent on CacheKV #352

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Expose parent on CacheKV #352

merged 4 commits into from
Nov 17, 2023

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Nov 16, 2023

Describe your changes and provide context

For EVM getProof endpoint, we'd need to call functions on the underlying iavl store, so we'd need a way to expose the parent store from a cachekv

Testing performed to validate your change

@codchen codchen requested a review from jewei1997 November 16, 2023 07:25
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Merging #352 (70ec9a1) into evm-temp (9ab3455) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           evm-temp     #352      +/-   ##
============================================
- Coverage     55.41%   55.41%   -0.01%     
============================================
  Files           620      620              
  Lines         51690    51692       +2     
============================================
+ Hits          28644    28645       +1     
- Misses        20962    20963       +1     
  Partials       2084     2084
Files Coverage Δ
store/cachekv/store.go 72.46% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

@codchen codchen changed the base branch from main to evm-temp November 17, 2023 03:35
@codchen codchen merged commit 635133e into evm-temp Nov 17, 2023
15 checks passed
@codchen codchen deleted the expose-parent branch November 17, 2023 03:58
codchen added a commit that referenced this pull request Jan 5, 2024
@codchen
Expose parent on CacheKV (#352)
f837d8f 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
codchen added a commit that referenced this pull request Jan 11, 2024
@codchen
Expose parent on CacheKV (#352)
fa168e6 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
stevenlanders pushed a commit that referenced this pull request Jan 30, 2024
@codchen @stevenlanders
Expose parent on CacheKV (#352)
0f15749 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Jan 31, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
117a276 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
stevenlanders pushed a commit that referenced this pull request Feb 6, 2024
@codchen @stevenlanders
Expose parent on CacheKV (#352)
120055c 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
stevenlanders pushed a commit that referenced this pull request Feb 8, 2024
@codchen @stevenlanders
Expose parent on CacheKV (#352)
c7cf095 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Feb 28, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
86fba5e 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Feb 28, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
d842a42 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 1, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
207bf12 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 4, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
304a89b 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 11, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
4d35c12 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 14, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
2e2d463 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 26, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
2e066c6 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 26, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
f50cde8 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Mar 27, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
783779b 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Apr 16, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
99de2f8 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Apr 19, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
2d633f1 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
udpatil pushed a commit that referenced this pull request Apr 19, 2024
@codchen @udpatil
Expose parent on CacheKV (#352)
e62658c 
## Describe your changes and provide context
For EVM getProof endpoint, we'd need to call functions on the underlying
iavl store, so we'd need a way to expose the parent store from a cachekv

## Testing performed to validate your change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewei1997 jewei1997 Awaiting requested review from jewei1997

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codchen