[occ] Implement basic multiversion store #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
reviewed
Oct 4, 2023
store/multiversion/store.go
Outdated
| s.mtx.Lock() | ||
| defer s.mtx.Unlock() | ||
|
|
||
| keyString := conv.UnsafeBytesToStr(key) |
There was a problem hiding this comment.
i'd prefer us to just use string casting here. If key bytes are mutated somehow the underlying map would be corrupted and would be difficult to debug
There was a problem hiding this comment.
what do you mean by mutated somehow? This is how cachekv currently implements the cache that maps between byte key and vals, so i would think there isnt too much risk in doing it this way?
There was a problem hiding this comment.
modified to use string cast for safety btw
|
|
||
| keyString := string(key) | ||
| s.tryInitMultiVersionItem(keyString) | ||
| s.multiVersionMap[keyString].Delete(index, incarnation) |
There was a problem hiding this comment.
does something ever get removed from the multiVersionMap? (maybe when the last existing index/incarnation is deleted?)
There was a problem hiding this comment.
no, because even "deletions" are tracked explicitly, as soon as we introduce an item for a key, that key will remain in the multiversion store map for the remainder of the block, because a later transaction may need to access that data. Once all transactions have completed processing, we can discard the multiversion map after committing to store
stevenlanders
approved these changes
Oct 5, 2023
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 2, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 25, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Feb 27, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
udpatil
added a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation ## Testing performed to validate your change Added unit tests for basic multiversion store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This implements the multiversion with basic functionality, but still needs additional work to implement the iterator functionality and/or persisting readsets for validation
Testing performed to validate your change
Added unit tests for basic multiversion store