Multiversion Item Implementation and Tests #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
changed the title
codchen
reviewed
Sep 19, 2023
| return vItem.value, found | ||
| } | ||
|
|
||
| func (item *multiVersionItem) Set(index int, value []byte) { |
There was a problem hiding this comment.
can we make nextIndex a field in multiVersionItem so that the caller does not need to track it? unless there is a use case where the caller need the ability to set a prev index
There was a problem hiding this comment.
we aren't necessarily going to have each item set to an index in increasing order, right? we'll need to know when we are writing a value which TX index the value is being wrirtten for. That is what this index will represent, so the setter SHOULD have it available
There was a problem hiding this comment.
ah right that makes sense
philipsu522
approved these changes
Sep 19, 2023
codchen
approved these changes
Sep 25, 2023
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Oct 17, 2023
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 2, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 8, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 18, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 25, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Jan 31, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
codchen
pushed a commit
that referenced
this pull request
Feb 6, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Feb 27, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
udpatil
added a commit
that referenced
this pull request
Mar 1, 2024
## Describe your changes and provide context Add multiversion store data structures file, and implement the multiversioned item ## Testing performed to validate your change Added unit tests to verify behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add multiversion store data structures file, and implement the multiversioned item
Testing performed to validate your change
Added unit tests to verify behavior