Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dry-run for TXs #306

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix --dry-run for TXs #306

merged 1 commit into from
Jun 30, 2023

Conversation

BrandonWeng
Copy link
Contributor

@BrandonWeng BrandonWeng commented Jun 30, 2023

Describe your changes and provide context

Cherry picks this change: cosmos/cosmos-sdk@4f1cc3a and some additional changes in client/tx/factory.go

Testing performed to validate your change

Goign to add integration tests in sei-chain for this and muilti-sig transactions

Unit tests and ran locally:

> seid tx bank send sei15nmrq83e2n25x9hzzhv8pchfaetda9jjyqwj4a sei15nmrq83e2n25x9hzzhv8pchfaetda9jjyqwj4a 1sei --from sei15nmrq83e2n25x9hzzhv8pchfaetda9jjyqwj4a  --chain-id sei-chain -b block -y --fees 20000usei --dry-run
gas estimate: 69765

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #306 (2ea7b8a) into main (24b93d5) will increase coverage by 0.03%.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   55.36%   55.39%   +0.03%     
==========================================
  Files         620      620              
  Lines       51611    51626      +15     
==========================================
+ Hits        28572    28598      +26     
+ Misses      20958    20946      -12     
- Partials     2081     2082       +1     
Impacted Files Coverage Δ
client/flags/flags.go 21.05% <0.00%> (ø)
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)
client/tx/factory.go 29.04% <52.94%> (+0.54%) ⬆️
client/context.go 63.38% <90.90%> (+11.14%) ⬆️
client/cmd.go 58.95% <100.00%> (ø)

... and 1 file with indirect coverage changes

@BrandonWeng BrandonWeng merged commit 6ecb719 into main Jun 30, 2023
@BrandonWeng BrandonWeng deleted the bweng-fix-dry-run branch June 30, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants