Always reset state between proposals #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Jun 13, 2023
alexanderbez
approved these changes
Jun 14, 2023
codchen
approved these changes
Jun 14, 2023
yzang2019
approved these changes
Jun 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 54.99% 55.18% +0.18%
==========================================
Files 619 619
Lines 51565 51569 +4
==========================================
+ Hits 28357 28456 +99
+ Misses 21163 21062 -101
- Partials 2045 2051 +6
|
BrandonWeng
added a commit
that referenced
this pull request
Jun 15, 2023
## Describe your changes and provide context Similar changes to here: cosmos/cosmos-sdk#15487 Our fork of cosmos-sdk has a custom integration to get ABCI++ working so I'd like @codchen to take a second look ## Testing performed to validate your change Unit tests
BrandonWeng
added a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit db47ec3.
BrandonWeng
added a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit db47ec3. ## Describe your changes and provide context With optimistic processing this is not applicable on our side ## Testing performed to validate your change Launched a cluster with 3.0.3, with only this change applied and see that it app hashes 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Similar changes to here:
cosmos/cosmos-sdk#15487
Our fork of cosmos-sdk has a custom integration to get ABCI++ working so I'd like @codchen to take a second look
Testing performed to validate your change
Unit tests