Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkTxResponse log to RPCResponse #227

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add checkTxResponse log to RPCResponse #227

merged 1 commit into from
Apr 24, 2023

Conversation

LCyson
Copy link
Contributor

@LCyson LCyson commented Apr 21, 2023

Describe your changes and provide context

This change adds back the log string to the rawLog of the RPCResponse.

This and sei-protocol/sei-tendermint#125 resolves the following issue:

On Cosmos Hub when a tx is broadcast with an incorrect sequence that endpoint will return a successful JSON RPC response with a payload that looks like this:

{"code":32,"codeSpace":"sdk","log":"account sequence mismatch, expected 3, got 4: incorrect account sequence","data":{},"events":[],"gasWanted":0,"gasUsed":0,"hash":{...}}


On the Sei node, when broadcasting a tx with incorrect sequence it returns a JSON RPC error response with an "Internal Error" code:

{"code":-32603,"message":"Internal error","data":"account sequence mismatch, expected 72, got 73: incorrect account sequence"}

Testing performed to validate your change

  • unit tests
  • e2e test

go.mod Outdated
@@ -145,7 +145,7 @@ replace (
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.7.0
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

github.com/tendermint/tendermint => github.com/sei-protocol/sei-tendermint v0.1.181
github.com/tendermint/tendermint => ../sei-tendermint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update once sei-protocol/sei-tendermint#125 is merged

@LCyson LCyson merged commit e6f0361 into main Apr 24, 2023
@Ucboss
Copy link

Ucboss commented May 10, 2023

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants