Add admin field to base vesting account #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
approved these changes
Apr 18, 2023
BrandonWeng
reviewed
Apr 18, 2023
| @@ -44,7 +45,7 @@ func NewMsgCreateVestingAccountCmd() *cobra.Command { | |||
| account can either be a delayed or continuous vesting account, which is determined | |||
| by the '--delayed' flag. All vesting accouts created will have their start time | |||
| set by the committed block's time. The end_time must be provided as a UNIX epoch | |||
| timestamp.`, | |||
| timestamp. You can also optionally configure the 'admin' field using the flag '--admin {addr}. This admin will be able to perform some administrative actions on the vesting account if set.`, | |||
There was a problem hiding this comment.
Looks like the vesting submodule doesn't have a query handler, is there a way to query or display the account admin from the CLI/RPC endpoint or add it a query handler or display it in seid q auth account(s)?
There was a problem hiding this comment.
it's returned when querying the actual account seid q auth account $addr
yeah good point, I'll add one in |
|
actually, @psu It seems like maybe we don't need a store migration, since when we query accounts created prior to the vesting account change, they show admin as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This allows for configuring vesting accounts with an admin
This also adds the cancelled_time field to indicate when a vesting account vesting progress is cancelled
Testing performed to validate your change
Added unit tests and tested with local sei