-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart node instead of panicing and exiting #218
Conversation
e1b9392
to
64b3018
Compare
I think the test failures are unrelated |
The test failures seems to be new, I think we should aim to fix them or at least figure out why they are failing. If they fail due to flakyness, then that's probably fine |
5bf81b6
to
3f8fbd6
Compare
2bd10c0
to
8306b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thing I'm slightly concerned about is that if we forcefully shut down the process (which I don't think it does) in the middle of a write to the database. This could cause some integrity issues and ultimately bork a machine. Can we:
- make sure we pause and wait for all graceful shutdown routines
- let it run repeatedly on a node for a while?
|
Describe your changes and provide context
Currently the node will only switch into blocksync mode if the whole process is restarted, this change aims to add a detection go routine and restart the node if it's behind configurable
Testing performed to validate your change
Artificially introduced latency so that the node would fall behind, and see that it self restarted node