Skip to content

Commit

Permalink
remove some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
udpatil committed Oct 6, 2023
1 parent 444af18 commit c760575
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions store/multiversion/mvkv.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ func (store *VersionIndexedStore) Get(key []byte) []byte {
if mvsValue != nil {
if mvsValue.IsEstimate() {
store.abortChannel <- scheduler.NewEstimateAbort(mvsValue.Index())
// TODO: is it safe to return nil here?
return nil
} else {
// This handles both detecting readset conflicts and updating readset if applicable
Expand Down Expand Up @@ -174,7 +173,6 @@ func (store *VersionIndexedStore) Delete(key []byte) {
store.setValue(key, nil, true, true)
}

// TODO: with this current implementation, if we check HAS and the underlying parent store has the value, the readset is still populated with key and value, so even if the value changes, although HAS would have the same result, we would still fail validation. Is this an issue?
// Has implements types.KVStore.
func (store *VersionIndexedStore) Has(key []byte) bool {
// necessary locking happens within store.Get
Expand Down

0 comments on commit c760575

Please sign in to comment.