-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display,name,symbol to tokenfactory denom creation #861
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
==========================================
+ Coverage 63.53% 63.61% +0.08%
==========================================
Files 250 250
Lines 15507 15533 +26
==========================================
+ Hits 9852 9882 +30
+ Misses 5187 5184 -3
+ Partials 468 467 -1
|
Can you add an integration test for this? Instruction are here: https://github.com/sei-protocol/sei-chain/tree/master/integration_test |
882b17f
to
762dd98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@philipsu522 We also need to add the new integration test to workflow so that CI can pick it up |
env: ADMIN_ADDR | ||
# Create denom | ||
- cmd: seid tx tokenfactory create-denom test --from admin --fees 2000usei | ||
env: PARAMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command is not PARAMS right?
38acfd4
to
db2076a
Compare
Describe your changes and provide context
x/bank requires that display, name and symbol for all denoms are valid. However, when exporting genesis we found that this is not the case.
This is an initial PoC. We need to backport (migrate all existing denoms) if this looks good.
Testing performed to validate your change