Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable FOK #810

Merged
merged 1 commit into from
May 26, 2023
Merged

Disable FOK #810

merged 1 commit into from
May 26, 2023

Conversation

LCyson
Copy link
Contributor

@LCyson LCyson commented May 26, 2023

Describe your changes and provide context

This PR temporarily disables FOK market order type.

Testing performed to validate your change

  • unit test

@LCyson LCyson requested review from philipsu522 and BrandonWeng May 26, 2023 20:52
@yzang2019
Copy link
Contributor

Does existing unit test already cover fok order will return error?

@LCyson LCyson merged commit 2f0543a into master May 26, 2023
@LCyson
Copy link
Contributor Author

LCyson commented May 26, 2023

Does existing unit test already cover fok order will return error?

this file wasn't covered by unit tests previously, will need to add tests when we add FOK back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzang2019 yzang2019 yzang2019 approved these changes

@BrandonWeng BrandonWeng BrandonWeng approved these changes

@philipsu522 philipsu522 Awaiting requested review from philipsu522

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LCyson @yzang2019 @BrandonWeng