Not charge gas for contract dependency loading #797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Since the number of times and timing of contract dependency loading can be different across nodes due to issues like process restart, transaction parallelization, etc., we decide to not charge gas for times when the dependencies need to be loaded from the store, so that the difference wouldn't cause non-determinism.
Using an infinite gas meter instead of the original gas meter + refund because we don't want this now "free" operation to cause panics (e.g. when the original meter is just about to run out of gas)
Testing performed to validate your change
unit tests + load test