Disable tx concurrency #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpatil
force-pushed
the
disable-tx-concurrency
branch
3 times, most recently
from
b9eda84 to
d33bd80
Compare
BrandonWeng
reviewed
May 21, 2023
Comment on lines
+1333
to
+1336
| // otherResults, ctx := app.BuildDependenciesAndRunTxs(ctx, txs) | ||
| otherResults := app.ProcessBlockSynchronous(ctx, txs) |
There was a problem hiding this comment.
could we leave a comment here or in the pr description around the plans for re-enabling it?
remove unnecessary statement
udpatil
force-pushed
the
disable-tx-concurrency
branch
from
d33bd80 to
c09e8fc
Compare
BrandonWeng
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This disables tx execution concurrency on non prioritized (non-oracle, dexregister msgs) txs
Testing performed to validate your change
Will test on a loadtest cluster