Clear dex memstate cache #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
commented
May 20, 2023
| @@ -23,7 +23,7 @@ type MemState struct { | |||
| } | |||
|
|
|||
| func NewMemState(storeKey sdk.StoreKey) *MemState { | |||
| contractsToProcess := datastructures.NewSyncSet[string]([]string{}) | |||
codchen
reviewed
May 20, 2023
| @@ -1207,6 +1208,9 @@ func (app *App) ProcessTxs( | |||
| // Clear the memcache context from the previous state as it failed, we no longer need to commit the data | |||
| ctx.ContextMemCache().Clear() | |||
|
|
|||
| oldDexMemStateCtx := context.WithValue(ctx.Context(), dexutils.DexMemStateContextKey, oldDexMemState) | |||
There was a problem hiding this comment.
memstate has deep pointers so we need to explicitly clear it like
dexMemState := dexutils.GetMemState(ctx.Context())
dexMemState.Clear(ctx)
dexMemState.ClearContractToDependencies()
codchen
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We need to clear the dex memcache
Testing performed to validate your change