Parallelize Sudo Deposit #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+192
to
+195
| go func() { | ||
| wg.Wait() | ||
| close(resultChan) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
yzang2019
approved these changes
May 15, 2023
philipsu522
approved these changes
May 15, 2023
Comment on lines
+174
to
+189
| go func(index int, contract types.ContractInfoV2) { | ||
| defer wg.Done() | ||
| if !contract.NeedOrderMatching || !contractToProcess.Contains(contract.ContractAddr) { | ||
| return | ||
| } | ||
| typedContractAddr := types.ContractAddress(contract.ContractAddr) | ||
| msg := keeperWrapper.GetDepositSudoMsg(sdkCtx, typedContractAddr) | ||
| if msg.IsEmpty() { | ||
| return | ||
| } | ||
| resultChan <- struct { | ||
| int | ||
| types.SudoOrderPlacementMsg | ||
| }{index, msg} | ||
|
|
||
| }(index, contract) |
Check notice
Code scanning / CodeQL
Spawning a Go routine
udpatil
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Optimize the sudo deposit calls and the message building
Testing performed to validate your change
Ran in the same loadtest cluster for the other contract optimizations