Remove liquidation logics from dex #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCyson
approved these changes
Apr 28, 2023
| @@ -16,10 +16,10 @@ var _ = strconv.Itoa(0) | |||
|
|
|||
| func CmdRegisterContract() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "register-contract [contract address] [code id] [need hook] [need order matching] [deposit] [dependency1,dependency2,...]", | |||
| Use: "register-contract [contract address] [code id] [(deprecated)] [need order matching] [deposit] [dependency1,dependency2,...]", | |||
There was a problem hiding this comment.
think we can just remove this flag here as only the spot-lite and vortex contract deployment scripts are using this cmd
There was a problem hiding this comment.
i think some infra tooling (e.g. loadtest) also relies on this so want to change it after we are done with all loadtesting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We've recognized liquidation as a vortex-specific feature rather than something generic to all exchange applications, so we removed the sudo call related to liquidation but didn't completely clean it up, which is fixed by this PR
Testing performed to validate your change
unit tests