Bump max wasm file size to 2MB #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
approved these changes
Apr 27, 2023
app/app.go
Outdated
| @@ -1578,5 +1578,5 @@ func (app *App) decorateContextWithDexMemState(base context.Context) context.Con | |||
|
|
|||
| func init() { | |||
| // override max wasm size to 1MB | |||
| wasmtypes.MaxWasmSize = 1024 * 1024 | |||
| wasmtypes.MaxWasmSize = 1280 * 1024 | |||
There was a problem hiding this comment.
any particular reason to choose this number vs. maybe just 2MB? also the comment above needs to be updated
There was a problem hiding this comment.
I'm inclined not to bump the uploadable wasm size too much as larger wasm file has negative impact on chain performance. Choosing this number to unblock Levana. We can also make a chain upgrade to adjust the param here, but let me know if you have a different thought
There was a problem hiding this comment.
will bump it to 2MB for now
philipsu522
approved these changes
Apr 27, 2023
LCyson
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This change bumps the maximal uploadable wasm file size from 1024 * 1024 to 1280 * 1024.
Testing performed to validate your change