[mint] Update mint distribution to be daily #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
force-pushed
the
sei-3710
branch
7 times, most recently
from
922ceae to
76c2d92
Compare
BrandonWeng
changed the title
BrandonWeng
commented
Apr 25, 2023
Comment on lines
-34
to
-35
| case bytes.HasPrefix(key, minttypes.LastTokenReleaseDate): | ||
| keyItems = append(keyItems, "LastTokenReleaseDate") |
There was a problem hiding this comment.
Not needed anymore
BrandonWeng
commented
Apr 25, 2023
scripts/old_initialize_local.sh
Outdated
Comment on lines
45
to
46
| cat ~/.sei/config/genesis.json | jq --arg start_date "$(date +"%Y-%m-%d")" --arg end_date "$(date -v+3d +"%Y-%m-%d")" '.app_state["mint"]["params"]["token_release_schedule"]=[{"start_date": $start_date, "end_date": $end_date, "token_release_amount": "999999999999"}]' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq --arg start_date "$(date -v+3d +"%Y-%m-%d")" --arg end_date "$(date -v+5d +"%Y-%m-%d")" '.app_state["mint"]["params"]["token_release_schedule"] += [{"start_date": $start_date, "end_date": $end_date, "token_release_amount": "999999999999"}]' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json |
There was a problem hiding this comment.
Two schedule for testing, first mint will occur in 1 min (epoch handler)
BrandonWeng
commented
Apr 25, 2023
Comment on lines
+89
to
+108
| func SortTokenReleaseCalendar(tokenReleaseSchedule []ScheduledTokenRelease) []ScheduledTokenRelease { | ||
| sort.Slice(tokenReleaseSchedule, func(i, j int) bool { | ||
| startDate1, _ := time.Parse(TokenReleaseDateFormat, tokenReleaseSchedule[i].GetStartDate()) | ||
| startDate2, _ := time.Parse(TokenReleaseDateFormat, tokenReleaseSchedule[j].GetStartDate()) | ||
| return startDate1.Before(startDate2) | ||
| }) | ||
| return tokenReleaseSchedule |
There was a problem hiding this comment.
Sorted so it's easier to detect overlaps and search for next release window
philipsu522
reviewed
Apr 25, 2023
| string denom = 4 [ | ||
| (gogoproto.moretags) = "yaml:\"denom\"" | ||
| ]; | ||
| string start_date = 1; // yyyy-mm-dd |
There was a problem hiding this comment.
i think we'll need to consider migration? maybe you can sync with @udpatil who did the same with x/slashing
There was a problem hiding this comment.
Ah yeah, good point, thanks!
x/mint/keeper/hooks_test.go
Outdated
| expectedAmount := int64(100000) | ||
| newMinter := seiApp.MintKeeper.GetMinter(ctx) | ||
|
|
||
| if i == 25 { |
There was a problem hiding this comment.
will we ever hit this?
| }, | ||
| }, | ||
| { | ||
| name: "Unsorted schedule", |
There was a problem hiding this comment.
do we want to allow an unsorted schedule? seems like it could be potentially messy
There was a problem hiding this comment.
I think we can raise a panic if it's unsorted but at that point, I think just sorting it and storing it by default would be a better user interface.
| require.Equal(t, postOutageTime.Format(minttypes.TokenReleaseDateFormat), newMinter.GetLastMintDate(), "Last mint date should be correct") | ||
| require.InDelta(t, 127315, newMinter.GetLastMintAmountCoin().Amount.Int64(), 1, "Minted amount should be correct") | ||
| require.InDelta(t, int64(1018522), int64(newMinter.GetRemainingMintAmount()), 24, "Remaining amount should be correct") | ||
| }) |
There was a problem hiding this comment.
can we finish the mitn release cycle and ensure all tokens are released?
philipsu522
approved these changes
Apr 26, 2023
philipsu522
reviewed
Apr 26, 2023
app/upgrades.go
Outdated
| @@ -62,6 +62,7 @@ var upgradesList = []string{ | |||
| "2.0.44beta", | |||
| "2.0.45beta", | |||
| "2.0.46beta", | |||
| "2.0.46beta-bweng-test", | |||
There was a problem hiding this comment.
mighht want to revert this before merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Will follow up with another PR to add a gov prop with updating the current release minter.
Previously the mint rewards are distributed to the block immediately following the mint event, this PR makes it such that the mints are distributed daily over a period of time (as defined in the mint parms). This incentivizes users to stake for longer periods of time rather just for the mint event.
This pretty much rewrites the entire mint module
Testing performed to validate your change
Unit test for individual methods and overall hook test
Simple e2e test:
Going to spin up a loadtest cluster and let it run for a couple of days and use metrics to observe mint events (final verification)
Tested upgrade path locally:
Before
After
