Remove other init scripts and improve init script comments #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
reviewed
Apr 21, 2023
|
|
||
| ~/go/bin/seid collect-gentxs | ||
| # update some params in genesis file for easier use of the chain localls (make gov props faster) | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["gov"]["deposit_params"]["max_deposit_period"]="300s"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json |
There was a problem hiding this comment.
Do we need this? Can we just use the default
There was a problem hiding this comment.
The default for gov is 2 days for normal and 1 day for expedited, which is too long for local chain
BrandonWeng
reviewed
Apr 21, 2023
| cat ~/.sei/config/genesis.json | jq --arg release_date "$(date +"%Y-%m-%d")" '.app_state["mint"]["params"]["token_release_schedule"]=[{"date": $release_date, "token_release_amount": "999999999999"}]' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["gov"]["voting_params"]["expedited_voting_period"]="4s"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["gov"]["voting_params"]["expedited_voting_period"]="10s"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["oracle"]["params"]["vote_period"]="1"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["distribution"]["params"]["community_tax"]="0.000000000000000000"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json |
There was a problem hiding this comment.
can we remove any unnecessary overrides
There was a problem hiding this comment.
which ones are unnecessary?
BrandonWeng
reviewed
Apr 21, 2023
| cat ~/.sei/config/genesis.json | jq --arg release_date "$(date +"%Y-%m-%d")" '.app_state["mint"]["params"]["token_release_schedule"]=[{"date": $release_date, "token_release_amount": "999999999999"}]' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["gov"]["voting_params"]["expedited_voting_period"]="4s"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["gov"]["voting_params"]["expedited_voting_period"]="10s"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json | ||
| cat ~/.sei/config/genesis.json | jq '.app_state["oracle"]["params"]["vote_period"]="1"' > ~/.sei/config/tmp_genesis.json && mv ~/.sei/config/tmp_genesis.json ~/.sei/config/genesis.json |
There was a problem hiding this comment.
Can we just set this to 1 in the code?
There was a problem hiding this comment.
1s? isnt that too fast to submit + vote yes?
There was a problem hiding this comment.
Oh im referring to "oracle"]["params"]["vote_period"]` i just updated it here https://github.com/sei-protocol/sei-chain/pull/717/files#diff-4f014297fd4b20647b36d9d0187633ac132726e7984acfabc3bc30d391b87371R28
Default was 10
philipsu522
approved these changes
Apr 21, 2023
| keyname=admin | ||
| #docker stop jaeger |
There was a problem hiding this comment.
might be nice to leave this
There was a problem hiding this comment.
sg, i havent recently uncommented to use this but could be useful to leave for the future if someone needs to use
udpatil
force-pushed
the
fix-init-scripts
branch
from
8e9a83c to
085e83e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Keep the relevant init script and add some comments + fail fast in script if error
Testing performed to validate your change
verified that the script works