Reject proposal if max block gas is exceeded #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
approved these changes
Mar 30, 2023
| func (app *App) checkTotalBlockGasWanted(ctx sdk.Context, txs [][]byte) bool { | ||
| totalGasWanted := uint64(0) | ||
| for _, tx := range txs { | ||
| decoded, err := app.txDecoder(tx) |
There was a problem hiding this comment.
Nit: If we have perf concern, we can make decode run in parallel, and then use atomic integer for calculating totalGasWanted
There was a problem hiding this comment.
yeah good point. I'll add it in in a later PR if we find this to be a bottleneck
philipsu522
approved these changes
Mar 30, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Implementation for https://github.com/sei-protocol/sei-chain/pull/new/tony-chen-max-block-gas-check
We want honest validators (i.e. validators who do not use a maliciously modified binary) to reject block proposals whose transactions' GasWanted add up to something greater than max block gas. Since transactions in block proposals are sent as raw bytes, the only place to decode them would be on application-level during ProcessProposal. For context, ProcessProposal is called during
prevotephase by validators, and if it returns a status ofREJECT, validators will vote nil.Testing performed to validate your change
unit test
integration test in a loadtest cluster with a modified node to verify such proposal will indeed be rejected