[oracle] Add slash window progress query #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonWeng
approved these changes
Mar 3, 2023
yzang2019
reviewed
Mar 3, 2023
proto/oracle/query.proto
Outdated
| @@ -196,6 +202,18 @@ message QueryAggregateVotesResponse { | |||
| repeated AggregateExchangeRateVote aggregate_votes = 1 [(gogoproto.nullable) = false]; | |||
| } | |||
|
|
|||
| // QuerySlashWindow is the request type for the | |||
| // Query/SlashWindow RPC method. | |||
| message QuerySlashWindow {} | |||
There was a problem hiding this comment.
Based on the above naming pattern, we should name this as QuerySlashWindowRequest right?
There was a problem hiding this comment.
ah yes good point, I'll fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
At the request of validators, a slash window progress query would be useful to have. This query is very similar to the Umee implementation that was mentioned as a useful endpoint.
Testing performed to validate your change
unit tests