Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dex][mint] Add long messages for dex and mint #624

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[dex][mint] Add long messages for dex and mint #624

merged 2 commits into from
Mar 2, 2023

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented Mar 2, 2023

Describe your changes and provide context

Adds long messages for dex and mint module CLI commands. @LCyson there's a TODO for you to clarify a bit more around the place-orders command since I don't have full context on the specific formatting of order placement.

Testing performed to validate your change

LCyson
LCyson approved these changes Mar 2, 2023
View reviewed changes
x/dex/client/cli/tx/tx_place_orders.go Outdated
Place orders on an orderbook specified by contract-address. Orders are represented as strings with the cancellation details separated by "?". Cancellation details format is OrderDirection?Quantity?Price?PriceAsset?QuoteAsset?OrderType?OrderData?AdditionalParams.

Example: "LONG?1.01?5?USDC?ATOM?LIMIT?"
`), // TODO: cyson clarify the formatting + provide some examples, it's a bit confusing how exactly the order detail should be composed
Copy link
Contributor

@LCyson LCyson Mar 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add the gitbook link here: https://docs.seinetwork.io/smart-contracts-and-local-development/dex-module-tutorial#placeorders

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Code Coverage

Package Line Rate Complexity Health
github.com/sei-protocol/sei-chain/aclmapping/bank 83% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/dex 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/oracle 100% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/staking 96% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/tokenfactory 96% 0 ✔
github.com/sei-protocol/sei-chain/aclmapping/utils 0% 0 ❌
github.com/sei-protocol/sei-chain/aclmapping/wasm 83% 0 ✔
github.com/sei-protocol/sei-chain/app 61% 0 ➖
github.com/sei-protocol/sei-chain/app/antedecorators 76% 0 ✔
github.com/sei-protocol/sei-chain/oracle/price-feeder/config 85% 0 ✔
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle 67% 0 ➖
github.com/sei-protocol/sei-chain/oracle/price-feeder/oracle/provider 49% 0 ❌
github.com/sei-protocol/sei-chain/oracle/price-feeder/router/v1 45% 0 ❌
github.com/sei-protocol/sei-chain/store/whitelist/cachemulti 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/kv 100% 0 ✔
github.com/sei-protocol/sei-chain/store/whitelist/multi 100% 0 ✔
github.com/sei-protocol/sei-chain/utils 59% 0 ➖
github.com/sei-protocol/sei-chain/utils/datastructures 90% 0 ✔
github.com/sei-protocol/sei-chain/utils/logging 100% 0 ✔
github.com/sei-protocol/sei-chain/x/dex 58% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/cache 87% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/client/cli/query 23% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/contract 51% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/exchange 94% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper 64% 0 ➖
github.com/sei-protocol/sei-chain/x/dex/keeper/abci 29% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/keeper/msgserver 78% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/keeper/query 82% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/migrations 88% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types 1% 0 ❌
github.com/sei-protocol/sei-chain/x/dex/types/utils 100% 0 ✔
github.com/sei-protocol/sei-chain/x/dex/types/wasm 86% 0 ✔
github.com/sei-protocol/sei-chain/x/epoch 11% 0 ❌
github.com/sei-protocol/sei-chain/x/epoch/keeper 66% 0 ➖
github.com/sei-protocol/sei-chain/x/epoch/types 2% 0 ❌
github.com/sei-protocol/sei-chain/x/mint 0% 0 ❌
github.com/sei-protocol/sei-chain/x/mint/keeper 61% 0 ➖
github.com/sei-protocol/sei-chain/x/mint/simulation 95% 0 ✔
github.com/sei-protocol/sei-chain/x/mint/types 3% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/client/cli 45% 0 ❌
github.com/sei-protocol/sei-chain/x/nitro/keeper 80% 0 ✔
github.com/sei-protocol/sei-chain/x/nitro/replay 63% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle 67% 0 ➖
github.com/sei-protocol/sei-chain/x/oracle/keeper 83% 0 ✔
github.com/sei-protocol/sei-chain/x/oracle/simulation 18% 0 ❌
github.com/sei-protocol/sei-chain/x/oracle/types 3% 0 ❌
github.com/sei-protocol/sei-chain/x/tokenfactory/keeper 85% 0 ✔
github.com/sei-protocol/sei-chain/x/tokenfactory/types 2% 0 ❌
Summary 15% (5195 / 34280) 0 ❌

@udpatil udpatil merged commit 2170b66 into master Mar 2, 2023
@udpatil udpatil deleted the client-long-msg branch March 2, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LCyson LCyson LCyson approved these changes

@philipsu522 philipsu522 philipsu522 approved these changes

@codchen codchen Awaiting requested review from codchen

@Kbhat1 Kbhat1 Awaiting requested review from Kbhat1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udpatil @philipsu522 @LCyson