-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add success count to the oracle query #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure to add a migration as well that will infer the success count from the block height + miss / abstain counts and update the store appropriately
Hmm we would need to do it when we register the upgrade handler right? Ill add a TODO in the upgrade handler file |
b04f1c3
to
26d48a7
Compare
1ae60c8
to
fe586b2
Compare
f6f1c94
to
2cef925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Describe your changes and provide context
Requested by one of the validators, right now we're just dividing the penalities by the window size to get the % error.
We would need to calculate how many successes we have based on the
((uint64)(ctx.BlockHeight())+1)%blocksPerPeriod - penalties
i thought it would just be easier to track it as a field and return it. This way we can emit metrics tooTesting performed to validate your change