[price-feeder] gracefully handle nil response for new provider #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
The response from
Dial
can sometimes be nil if there are specific errors. However, the defer assumes that there will never be a nil response, so attempting to get theBody
from response causes a nil pointer panic. The true correct assumption is that body is non-nil IFF response is non-nil, so we want to have a check for non-nil response prior toClose
ing the body.Testing performed to validate your change