Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ct cli to use SDK coin format #1977

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Dec 6, 2024

Describe your changes and provide context

Use {amount}{denom} format in CT cli

Testing performed to validate your change

  • integration test
  • local functional test

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.12%. Comparing base (81c0d5f) to head (407ee50).
Report is 45 commits behind head on feature/ct_types.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/ct_types    #1977      +/-   ##
====================================================
- Coverage             61.57%   60.12%   -1.46%     
====================================================
  Files                   263      283      +20     
  Lines                 23306    25947    +2641     
====================================================
+ Hits                  14351    15601    +1250     
- Misses                 7948     9207    +1259     
- Partials               1007     1139     +132     

see 4 files with indirect coverage changes

Copy link
Contributor

@mj850 mj850 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved!

@dssei dssei merged commit ead2625 into feature/ct_types Dec 6, 2024
41 of 43 checks passed
@dssei dssei deleted the use_coin_parser_inct_cli branch December 6, 2024 21:49
mj850 pushed a commit that referenced this pull request Dec 7, 2024
* refactor ct cli to use coin format like e.g. 1usei

* update integration tests

* formatting

* update integration tests

* update integration tests - 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants