-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BigInt in CT Module #1966
Merged
Merged
Use BigInt in CT Module #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1966 +/- ##
====================================================
- Coverage 61.57% 59.96% -1.62%
====================================================
Files 263 283 +20
Lines 23306 25883 +2577
====================================================
+ Hits 14351 15520 +1169
- Misses 7948 9224 +1276
- Partials 1007 1139 +132
|
dssei
approved these changes
Dec 3, 2024
mj850
added a commit
that referenced
this pull request
Dec 7, 2024
* save * backend tests passing * test * types test * acl tests * utils * codeql * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We currently represent balances in the CT module as uint64s. However, it is possible that the balances exceed the limits of uint64s, especially for decrypted available balances and pending balances.
We need to use big.Ints instead of uint64 to represent balance values.
Testing performed to validate your change
Updated Unit tests and integration tests