Ct ACL mappings #1947
Merged
Ct ACL mappings #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ct_acl_mappings
- fix init account test (cause of new check)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1947 +/- ##
====================================================
- Coverage 61.57% 60.40% -1.18%
====================================================
Files 263 282 +19
Lines 23306 25600 +2294
====================================================
+ Hits 14351 15463 +1112
- Misses 7948 9003 +1055
- Partials 1007 1134 +127
|
mj850
approved these changes
Nov 19, 2024
| availableBalance := initialAvailableBalance | ||
| pendingBalance := initialPendingBalance | ||
|
|
||
| // Extract the bottom 16 bits (rightmost 16 bits) |
There was a problem hiding this comment.
There's the utils function for this now
mj850
pushed a commit
that referenced
this pull request
Dec 7, 2024
* - add acl mapping for MsgTransfer * transfer message acl dependency tests * acls for initialize account and deposit * acls for withdraw message * acls for apply pending balance * - acls for close account - fix init account test (cause of new check) * formatting * self-review teaks * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Ct ACL mappings
Testing performed to validate your change