Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis draft #1924

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Genesis draft #1924

merged 7 commits into from
Nov 7, 2024

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Nov 7, 2024

Describe your changes and provide context

Testing performed to validate your change

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 27.43363% with 82 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (32c89cd) to head (d6cc4ce).
Report is 32 commits behind head on feature/ct_types.

Files with missing lines Patch % Lines
x/confidentialtransfers/types/genesis.go 0.00% 24 Missing ⚠️
x/confidentialtransfers/keeper/genesis.go 42.42% 15 Missing and 4 partials ⚠️
x/confidentialtransfers/keeper/msg_server.go 5.26% 18 Missing ⚠️
x/confidentialtransfers/keeper/keeper.go 60.86% 9 Missing ⚠️
x/confidentialtransfers/types/params.go 0.00% 8 Missing ⚠️
x/confidentialtransfers/types/keys.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/ct_types    #1924      +/-   ##
====================================================
- Coverage             61.36%   61.13%   -0.23%     
====================================================
  Files                   263      274      +11     
  Lines                 23306    24350    +1044     
====================================================
+ Hits                  14301    14886     +585     
- Misses                 8001     8374     +373     
- Partials               1004     1090      +86     
Files with missing lines Coverage Δ
app/app.go 66.37% <100.00%> (+0.02%) ⬆️
x/confidentialtransfers/types/keys.go 0.00% <0.00%> (ø)
x/confidentialtransfers/types/params.go 0.00% <0.00%> (ø)
x/confidentialtransfers/keeper/keeper.go 24.24% <60.86%> (ø)
x/confidentialtransfers/keeper/msg_server.go 10.00% <5.26%> (ø)
x/confidentialtransfers/keeper/genesis.go 42.42% <42.42%> (ø)
x/confidentialtransfers/types/genesis.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@dssei dssei marked this pull request as ready for review November 7, 2024 20:22
@dssei dssei merged commit 94dce54 into feature/ct_types Nov 7, 2024
27 of 28 checks passed
@dssei dssei deleted the ct_genesis branch November 7, 2024 20:31
mj850 pushed a commit that referenced this pull request Dec 7, 2024
* Genesis draft

* revert evm params

* revert evm params -2

* working simple test

* linting

* addressing linter errors

* remove creating address for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant