Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deposit and InitializeAccount types #1921

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Add Deposit and InitializeAccount types #1921

merged 9 commits into from
Nov 5, 2024

Conversation

mj850
Copy link
Contributor

@mj850 mj850 commented Nov 4, 2024

Describe your changes and provide context

Adds the Deposit and InitializeAccount types to the CT module.

Testing performed to validate your change

Unit tests

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 69.20152% with 81 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (32c89cd) to head (873d84f).
Report is 31 commits behind head on feature/ct_types.

Files with missing lines Patch % Lines
x/confidentialtransfers/types/msgs.go 63.82% 41 Missing and 10 partials ⚠️
x/confidentialtransfers/types/zk.go 80.90% 14 Missing and 7 partials ⚠️
x/confidentialtransfers/types/codec.go 25.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/ct_types    #1921      +/-   ##
====================================================
- Coverage             61.36%   61.13%   -0.23%     
====================================================
  Files                   263      270       +7     
  Lines                 23306    24201     +895     
====================================================
+ Hits                  14301    14796     +495     
- Misses                 8001     8323     +322     
- Partials               1004     1082      +78     
Files with missing lines Coverage Δ
x/confidentialtransfers/types/codec.go 40.00% <25.00%> (ø)
x/confidentialtransfers/types/zk.go 63.42% <80.90%> (ø)
x/confidentialtransfers/types/msgs.go 61.21% <63.82%> (ø)

... and 5 files with indirect coverage changes

@mj850 mj850 merged commit 169c150 into feature/ct_types Nov 5, 2024
27 of 29 checks passed
@mj850 mj850 deleted the mj/ctMod2 branch November 5, 2024 19:54
mj850 added a commit that referenced this pull request Dec 7, 2024
* new types

* add deposit to msgs

* add import issues

* revert evm/params to old state

* withdraw with tests

* small changes

* refactor and add tests

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant