CT types - Apply balance close account #1919
Conversation
dssei
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1919 +/- ##
====================================================
- Coverage 61.37% 61.25% -0.12%
====================================================
Files 267 267
Lines 23798 23906 +108
====================================================
+ Hits 14606 14644 +38
- Misses 8133 8190 +57
- Partials 1059 1072 +13
|
| message MsgCloseAccount { | ||
| string address = 1; | ||
| string denom = 2; | ||
| CloseAccountProof proof = 3; |
There was a problem hiding this comment.
Can we call this proofs instead for consistency
| } | ||
|
|
||
| func (c *CloseAccountProof) Validate() error { | ||
| if c.ZeroAvailableBalanceProof == nil || c.ZeroPendingBalanceLoProof == nil || c.ZeroPendingBalanceHiProof == nil { |
There was a problem hiding this comment.
Just a thought: Should we make the validate() calls chain validate the child proofs here as well (instead of just checking for nil). Seems like it would be what the validate call should do instead of making that the responsibility of FromProto.
| return nil | ||
| } | ||
|
|
||
| func (z *ZeroBalanceProof) ToProto(zkp *zkproofs.ZeroBalanceProof) *ZeroBalanceProof { |
There was a problem hiding this comment.
Not actional for this PR but i'm planning to rework all the ToProto calls to make them just regular constructors NewZeroBalanceProof(zkp*zkproofs.ZeroBalanceProof) *ZeroBalanceProof instead of a instance method of z, since it doesn't actually use z.
* pending balance type * convert apply pending balance to a message type * close account type
Describe your changes and provide context
Testing performed to validate your change