Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use wasm-to-evm gas limit for all interop operations #1912

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

blindchaser
Copy link
Contributor

Describe your changes and provide context

  • Make the lookup of GetDeliverTxHookWasmGasLimit use an infinite gas meter (10k gas)
  • Use the DeliverTxHookWasmGasLimit parameter to govern the whole method, including
    • Setting Transient Receipt
    • Lookups like translating CW20 events
    • GetEVMAddressOrDefault
    • AppendToEvmTxDeferredInfo

Testing performed to validate your change

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.25%. Comparing base (32c89cd) to head (7dc8ad6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   61.36%   61.25%   -0.11%     
==========================================
  Files         263      263              
  Lines       23306    23308       +2     
==========================================
- Hits        14301    14277      -24     
- Misses       8001     8028      +27     
+ Partials     1004     1003       -1     
Files with missing lines Coverage Δ
app/receipt.go 79.69% <100.00%> (+0.15%) ⬆️
app/seidb.go 88.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@blindchaser blindchaser merged commit 6a3c5f3 into main Oct 30, 2024
49 checks passed
@blindchaser blindchaser deleted the yiren/gas-limit-interop-ops branch October 30, 2024 16:02
philipsu522 pushed a commit that referenced this pull request Oct 30, 2024
* refactor: use wasm-to-evm gas limit for all interop operations

* fix cosmos dependency

* add large number wasm events note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants