Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply deliver hook gas limit for receipt side effects #1910

Closed
wants to merge 10 commits into from

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • set transient receipt was being governed by the transaction gas limit
  • this gas limit isn't actually charged against the transaction (receipt already rendered)
  • the change is to make this limited by the hook gas limit which is configured

Testing performed to validate your change

  • integration test passes

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (32c89cd) to head (7032b96).

Files with missing lines Patch % Lines
app/test_state_store.go 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
- Coverage   61.36%   61.34%   -0.02%     
==========================================
  Files         263      263              
  Lines       23306    23318      +12     
==========================================
+ Hits        14301    14305       +4     
- Misses       8001     8010       +9     
+ Partials     1004     1003       -1     
Files with missing lines Coverage Δ
app/receipt.go 79.53% <100.00%> (ø)
app/upgrades.go 40.74% <ø> (ø)
app/test_state_store.go 56.14% <0.00%> (-2.91%) ⬇️

... and 1 file with indirect coverage changes

@stevenlanders stevenlanders changed the base branch from v6.0.0-release to main October 29, 2024 20:18
@stevenlanders
Copy link
Contributor Author

closing in favor of #1911

@stevenlanders stevenlanders deleted the use-deliver-hook-ctx branch October 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants