Add endpoint to estimate gas after simulating calls #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -95,6 +95,18 @@ | |||
| return estimate, err | |||
| } | |||
|
|
|||
| func (s *SimulationAPI) EstimateGasAfterCalls(ctx context.Context, args ethapi.TransactionArgs, calls []ethapi.TransactionArgs, blockNrOrHash *rpc.BlockNumberOrHash, overrides *ethapi.StateOverride) (result hexutil.Uint64, returnErr error) { | |||
| startTime := time.Now() | |||
Check warning
Code scanning / CodeQL
Calling the system time Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
- Coverage 61.25% 61.24% -0.02%
==========================================
Files 263 263
Lines 23275 23285 +10
==========================================
+ Hits 14257 14260 +3
- Misses 8011 8016 +5
- Partials 1007 1009 +2
|
jewei1997
approved these changes
Oct 2, 2024
codchen
force-pushed
the
multitx-estimategas
branch
from
3ee6b8d to
7aae0c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
There are cases when gas estimation needs to be done based on certain simulated states which cannot be statically inputted as state overrides. One example is to estimate gas for an ERC20 transferFrom while assuming the allowance is in place.
This PR (together with sei-protocol/go-ethereum#35) adds a new endpoint
eth_estimateGasAfterCallsto support such use cases.Testing performed to validate your change
unit test