Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapp tests - update contract deployment #1874

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

kollegian
Copy link

Describe your changes and provide context

Testing performed to validate your change

Copy link
Contributor

@besated besated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments, looks good though! how are these tests run? can it be run via github actions?

@@ -0,0 +1,6 @@
{
"marketplace": "0x305E8dc769aae003c17fB08b9cc9108Cb4630E79",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these constants or different for each chain?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are for the arctic 1, and already deployed. I didnt create another config for atlantic-2, on the basis that they should be identical but I can deploy and create another config for atlantic 2 as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, just wanted to make sure it would be identical on atlantic-2

"testnet": "https://rpc-testnet.sei-apis.com",
"devnet": "https://rpc-arctic-1.sei-apis.com"
"devnet": "https://rpc-arctic-1.sei-apis.com",
"devnetFastTrack": "https://rpc-arctic-1.sei-apis.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can devnetFastTrack just use the same rpc as devnet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated.

@@ -43,5 +52,14 @@ module.exports = {
count: 1
},
},
devnetFastTrack: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this config different than devnet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually they are the same, removed and introduced another flag to the command -f. if passed with devnet it will run against already deployed contract, if passed with seicluster, it will create a config file where it records the contract addresses on the first iteration and run for the subsequent times based on this config file.

@@ -0,0 +1,6 @@
{
"marketplace": "0x305E8dc769aae003c17fB08b9cc9108Cb4630E79",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, just wanted to make sure it would be identical on atlantic-2

@kollegian kollegian force-pushed the dapp-tests/update-contract-deployment branch from b34b929 to d8241fe Compare October 9, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants