-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapp tests - update contract deployment #1874
base: main
Are you sure you want to change the base?
Dapp tests - update contract deployment #1874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple comments, looks good though! how are these tests run? can it be run via github actions?
@@ -0,0 +1,6 @@ | |||
{ | |||
"marketplace": "0x305E8dc769aae003c17fB08b9cc9108Cb4630E79", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these constants or different for each chain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are for the arctic 1, and already deployed. I didnt create another config for atlantic-2, on the basis that they should be identical but I can deploy and create another config for atlantic 2 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, just wanted to make sure it would be identical on atlantic-2
"testnet": "https://rpc-testnet.sei-apis.com", | ||
"devnet": "https://rpc-arctic-1.sei-apis.com" | ||
"devnet": "https://rpc-arctic-1.sei-apis.com", | ||
"devnetFastTrack": "https://rpc-arctic-1.sei-apis.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can devnetFastTrack
just use the same rpc as devnet
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated.
@@ -43,5 +52,14 @@ module.exports = { | |||
count: 1 | |||
}, | |||
}, | |||
devnetFastTrack: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this config different than devnet
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually they are the same, removed and introduced another flag to the command -f. if passed with devnet it will run against already deployed contract, if passed with seicluster, it will create a config file where it records the contract addresses on the first iteration and run for the subsequent times based on this config file.
@@ -0,0 +1,6 @@ | |||
{ | |||
"marketplace": "0x305E8dc769aae003c17fB08b9cc9108Cb4630E79", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, just wanted to make sure it would be identical on atlantic-2
985ecd8
to
9da7205
Compare
b34b929
to
d8241fe
Compare
Describe your changes and provide context
Testing performed to validate your change