Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use GetParamsIfExists() to fetch old params #1842

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

blindchaser
Copy link
Contributor

Describe your changes and provide context

Testing performed to validate your change

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (c2a0d85) to head (f3df470).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   60.69%   60.67%   -0.03%     
==========================================
  Files         259      259              
  Lines       22748    22752       +4     
==========================================
- Hits        13808    13804       -4     
- Misses       7956     7966      +10     
+ Partials      984      982       -2     
Files with missing lines Coverage Δ
x/evm/keeper/params.go 74.28% <100.00%> (+3.31%) ⬆️
x/evm/migrations/migrate_deliver_tx_gas_limit.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@blindchaser blindchaser changed the title fix: use GetParamsIfExists() to fetch old params to avoid panic fix: use GetParamsIfExists() to fetch old params Sep 1, 2024
@blindchaser blindchaser merged commit 7e79510 into main Sep 3, 2024
50 checks passed
@blindchaser blindchaser deleted the yiren/fix-v12-params branch September 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants