feat: add CLI and RPC endpoint from Pointee to Pointer mapping #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support querying a given pointee to retrieve the corresponding pointer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 60.57% 60.90% +0.33%
==========================================
Files 259 259
Lines 22752 22824 +72
==========================================
+ Hits 13783 13902 +119
+ Misses 7987 7936 -51
- Partials 982 986 +4
|
codchen
reviewed
Aug 30, 2024
philipsu522
reviewed
Sep 4, 2024
| @@ -47,3 +47,47 @@ func TestQueryPointer(t *testing.T) { | |||
| require.Nil(t, err) | |||
| require.Equal(t, types.QueryPointerResponse{Pointer: seiAddr5.String(), Version: uint32(erc721.CurrentVersion), Exists: true}, *res) | |||
| } | |||
|
|
|||
| func TestQueryPointee(t *testing.T) { | |||
There was a problem hiding this comment.
can we also test for invalid / not registered yet?
There was a problem hiding this comment.
good point will add it
philipsu522
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change