Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gov proposal v2 for native pointer #1711

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jun 3, 2024

Describe your changes and provide context

Add a new gov proposal type to register pointer for native tokens by providing only metadata instead of a deployed contract address, to make sure all pointers are running the same version.

Some notes:

  • all other existing gov types for pointer have been disabled (but not removed). We can remove them once we are sure there is no more inflight proposals
  • right now this new pathway doesn't implement "static address" for pointers. This will be part the larger change for pointer address

Testing performed to validate your change

unit test

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 36 lines in your changes missing coverage. Please review.

Project coverage is 60.43%. Comparing base (3862f3b) to head (0ae7350).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   60.54%   60.43%   -0.12%     
==========================================
  Files         370      370              
  Lines       27367    27407      +40     
==========================================
- Hits        16570    16564       -6     
- Misses       9673     9713      +40     
- Partials     1124     1130       +6     
Files Coverage Δ
x/evm/types/codec.go 52.00% <100.00%> (+0.64%) ⬆️
x/evm/types/gov.go 22.28% <100.00%> (+12.49%) ⬆️
x/evm/handler.go 10.25% <0.00%> (-0.56%) ⬇️
x/evm/gov.go 49.36% <53.42%> (-50.64%) ⬇️

... and 3 files with indirect coverage changes

@codchen codchen force-pushed the pointer-gov-metadata-only branch from 708c418 to 0ae7350 Compare June 5, 2024 04:15
@codchen codchen merged commit 083588f into main Jun 5, 2024
49 checks passed
@codchen codchen deleted the pointer-gov-metadata-only branch June 5, 2024 08:14
@0xskinnyg
Copy link

If we have set-denom-metadata on the Cosmos side why can't we have a similar command for the EVM pointer instead of having to submit a proposal?

This is hard for small projects as you have to deposit 3,500 SEI and have around 2bn votes for the proposal to go through.

From my personal experience, I've been trying to get help to make my proposal go through for the last 2 weeks and it has been unsuccessful so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants