Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native associate tx type #1694

Merged
merged 1 commit into from
May 24, 2024
Merged

Add native associate tx type #1694

merged 1 commit into from
May 24, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented May 21, 2024

Describe your changes and provide context

Add a cosmos TX type that allows forced address association for free. The condition is the same as EVM associate tx:

  • the account exists with at least 1wei
  • the account hasn't been associated

Usage:

seid tx evm native-associate <your custom msg> --from=<your key> --broadcast-mode=block

Testing performed to validate your change

local sei
unit test

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 60.62%. Comparing base (e949a96) to head (62da821).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
- Coverage   60.67%   60.62%   -0.05%     
==========================================
  Files         368      369       +1     
  Lines       26978    27034      +56     
==========================================
+ Hits        16369    16390      +21     
- Misses       9493     9528      +35     
  Partials     1116     1116              
Files Coverage Δ
app/ante.go 54.11% <100.00%> (ø)
...pp/antedecorators/accesscontrol_wasm_dependency.go 2.46% <ø> (+0.03%) ⬆️
app/app.go 65.02% <100.00%> (ø)
x/evm/keeper/msg_server.go 76.44% <100.00%> (+0.17%) ⬆️
x/evm/ante/preprocess.go 74.91% <0.00%> (-1.33%) ⬇️
app/antedecorators/gasless.go 78.16% <30.76%> (-5.29%) ⬇️
x/evm/types/message_associate.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@stevenlanders stevenlanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - it may be good to add a hardhat test in just to get the end-to-end scenario

@codchen codchen merged commit de00a65 into main May 24, 2024
47 checks passed
@codchen codchen deleted the native-associate branch May 24, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants