Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate dex #1686

Merged
merged 11 commits into from
Jul 8, 2024
Merged

Deprecate dex #1686

merged 11 commits into from
Jul 8, 2024

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented May 17, 2024

Describe your changes and provide context

Testing performed to validate your change

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.11%. Comparing base (f9be5b2) to head (bb6aab8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
+ Coverage   60.94%   61.11%   +0.16%     
==========================================
  Files         374      251     -123     
  Lines       27300    21850    -5450     
==========================================
- Hits        16639    13354    -3285     
+ Misses       9534     7552    -1982     
+ Partials     1127      944     -183     
Files Coverage Δ
aclmapping/bank/mappings.go 100.00% <ø> (ø)
app/ante.go 54.43% <ø> (+0.85%) ⬆️
app/antedecorators/gasless.go 78.99% <ø> (+0.82%) ⬆️
app/test_helpers.go 60.00% <ø> (-0.17%) ⬇️
app/app.go 64.74% <18.18%> (-1.34%) ⬇️

... and 8 files with indirect coverage changes

@udpatil udpatil marked this pull request as ready for review June 12, 2024 13:56
@udpatil udpatil merged commit b3204f9 into main Jul 8, 2024
47 of 48 checks passed
@udpatil udpatil deleted the deprecate-dex branch July 8, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants