-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message type to associate CW contract address #1681
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
- Coverage 60.91% 60.86% -0.06%
==========================================
Files 367 368 +1
Lines 26811 26848 +37
==========================================
+ Hits 16333 16342 +9
- Misses 9367 9394 +27
- Partials 1111 1112 +1
|
} | ||
evmAddr := common.BytesToAddress(addr) | ||
existingEvmAddr, ok := server.GetEVMAddress(ctx, addr) | ||
if ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to handle the case where ok == false ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the case where we set the association (because no existing association)
if someone tries to send an NFT to a contract address and it is not associated, what do they see? |
the tx would fail with an error |
Describe your changes and provide context
Add a new
AssociateContractAddress
message type for CW contracts to be explicitly associated with their EVM address counterparts.Testing performed to validate your change
unit tests
local Sei