Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Fix contract deploy receipts #1618

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • to should be nil (instead of 0x00000..) on contract deploy
  • contractAddress should only be populated if to is nil (not for factory deploys)

Testing performed to validate your change

  • unit test

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.69%. Comparing base (954bd21) to head (c5fe7d1).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   61.46%   61.69%   +0.23%     
==========================================
  Files         365      365              
  Lines       26107    26172      +65     
==========================================
+ Hits        16047    16148     +101     
+ Misses       8994     8953      -41     
- Partials     1066     1071       +5     
Files Coverage Δ
evmrpc/tx.go 66.20% <100.00%> (+0.47%) ⬆️

... and 4 files with indirect coverage changes

@stevenlanders stevenlanders merged commit 2427f30 into main May 2, 2024
47 of 48 checks passed
@stevenlanders stevenlanders deleted the fix-contract-deploy-receipts branch May 2, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants