Add association logic in simulate #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Apr 30, 2024
| if !associated { | ||
| seiAddr, associatedNow := b.keeper.GetSeiAddress(b.ctxProvider(LatestCtxHeight), msg.From) | ||
| if !associatedNow { | ||
| return nil, vm.BlockContext{}, nil, nil, fmt.Errorf("address %s is not associated in the latest height", msg.From.Hex()) |
There was a problem hiding this comment.
the test failing suggests that if it's not associated and not associated now it should still be valid?
codchen
force-pushed
the
associate-in-simulate
branch
2 times, most recently
from
44293e1 to
67c79bd
Compare
codchen
force-pushed
the
associate-in-simulate
branch
from
67c79bd to
c56b469
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
+ Coverage 61.46% 61.65% +0.18%
==========================================
Files 365 365
Lines 26107 26135 +28
==========================================
+ Hits 16047 16113 +66
+ Misses 8994 8952 -42
- Partials 1066 1070 +4
|
philipsu522
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change